Use 72 WU instead of 73 WU for signature weight #4208
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
jkczyz
force-pushed
the
2025-11-signature-weight
branch
from
edd3851 to
39fc8fb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4208 +/- ##
==========================================
- Coverage 89.30% 89.29% -0.01%
==========================================
Files 180 180
Lines 137913 137949 +36
Branches 137913 137949 +36
==========================================
+ Hits 123159 123179 +20
- Misses 12142 12157 +15
- Partials 2612 2613 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
jkczyz
force-pushed
the
2025-11-signature-weight
branch
from
39fc8fb to
54bcda8
Compare
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Add a commit to use a 95% fee rate tolerance when checking the remote, like Eclair. Let me know if you prefer to leave that to a separate PR.
jkczyz
force-pushed
the
2025-11-signature-weight
branch
from
54bcda8 to
63bb5ed
Compare
|
Squahsed |
When estimating signature weight, 73 WU was used in some places while 72 WU was used in others. Consistently use 72 WU and replace hardcoded values with constants. 73 WU signatures are non-standard and won't be produced by LDK. Additionally, using 73 WU along with grind_signatures adjustment is nonsensical.
When estimating the splice funding transaction fees, adjust for grind_signatures. Since LDK supplies one of the signatures, only adjust by 1 WU even though spending the shared input requires two signatures.
The interactive-tx construction protocol uses an agreed upon fee rate. Since the bitcoind coin selection algorithm may underpay fees when no change output is needed, providing a tolerance when checking if the remote's fee contribution could avoid some unexpected failures. This commit introduces a 95% tolerance similar to Eclair.
jkczyz
force-pushed
the
2025-11-signature-weight
branch
from
63bb5ed to
d88395f
Compare
|
Dropped the linter fix as it was merged in #4212. |
3 participants
When estimating signature weight, 73 WU was used in some places while 72 WU was used in others. Consistently use 72 WU and replace hardcoded values with constants. 73 WU signatures are non-standard and won't be produced by LDK. Additionally, using 73 WU along with
grind_signaturesadjustment is nonsensical.