review_patch: CLI command for AI code review #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 28, 2025 11:49
-This is currently ran on CLI but in future, the entry point might be slightly modified to fit into the linux CI system -The end goal of this project is to integrate an AI code reviewer into our CI process Signed-off-by: Zinc Lim <zinclim@meta.com>
Getting each commit title, message and diff should be sufficient for our ai to do an automated review Signed-off-by: Zinc Lim <zinclim@meta.com>
Signed-off-by: Zinc Lim <zinclim@meta.com>
- Note that it only works in the EC2 instance. Run python3 "review_patch.py --series <series id>" - In future, we will refine the AI by using MCP and codebase indexing in https://github.com/facebookexperimental/semcode.git Subject Signed-off-by: Zinc Lim <zinclim@meta.com>
kuba-moo
requested changes
Oct 29, 2025
| 2. Linux kernel coding style | ||
| 3. Memory safety | ||
| 4. Security concerns | ||
| 5. Performance implications |
There was a problem hiding this comment.
The prompt should be loaded from Chris's repo (expect a path to it via config), I'm surprised to see this here..
|
|
||
| body_dict = { | ||
| "anthropic_version": os.environ.get("BEDROCK_ANTHROPIC_VERSION"), | ||
| "max_tokens": int(os.environ.get("BEDROCK_MAX_TOKENS")), |
There was a problem hiding this comment.
I think we should consistently use config rather than env?
| for patch in series["patches"]: | ||
| log_open_sec(f'Processing patch id {patch["id"]}') | ||
|
|
||
| page = requests.get(patch["url"]).json() |
There was a problem hiding this comment.
I thought pw has a method for getting the patch, doesn't it? Better to stick to using pw 'cause it does all the retry and user agent config that we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end goal is to integrate automated code review with Claude into our CI workflow. As a first step, I've implemented the following CLI command:
To generate an AI code review for all patches in that series.
Note that this only works in our new ai-runner EC2 instance.