DAT-20877: update WEB_URL construction for SDKMAN package distribution #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandroav
approved these changes
Oct 1, 2025
Contributor
Author
|
after this is merged: sdkman/sdkman-db-migrations#741 , I’ll run https://github.com/liquibase/liquibase-pro/actions/workflows/secure-release-orchestrator.yml commenting out everything except SDKMAN in a branch and pointing https://github.com/liquibase/liquibase-pro/blob/master/.github/workflows/secure-release-orchestrator.yml#L92 to DAT-20877 |
- Resolved conflict in package.yml SDKMAN step - Combined DAT-20877 SDKMAN URL fixes with DAT-20985 liquibase-secure skip logic - Kept continue-on-error: true to ensure other package managers continue if SDKMAN fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⏺ Summary of Changes
Problem: SDKMAN couldn't access the package URLs due to two issues:
https://package.liquibase.com/downloads/oss//liquibase-5.0.0.zip
- Fix: Removed the extra / separator in the curl command
- OSS: Was /downloads/sdkman/oss/ → Changed to /downloads/oss/sdkman/
- Secure: Was /downloads/sdkman/secure/ → Changed to /downloads/secure/sdkman/
- Fix: Reordered path segments to match the Scarf.sh "Desired path format" from your screenshots
These changes ensure SDKMAN receives valid, publicly accessible URLs through Scarf.sh that properly route to the S3-hosted packages.