Skip to content

[LLDB] Skip TestMultipleSlides.py on Windows #165604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

[LLDB] Skip TestMultipleSlides.py on Windows #165604

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0180d12
[LLDB] Skip TestMultipleSlides.py on Windows
Nerixyz Oct 29, 2025
8055f76
fix: explanation
Nerixyz Oct 29, 2025
15f3ea5
fix: xfail on Windows
Nerixyz Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True

# The intermediate object main.o is compiled without debug info, but
# a.out is linked with `-gdwarf` on Windows. This creates a PDB.
Copy link
Member

@Michael137 Michael137 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does -gdwarf make LLD create a PDB? Seems counterintuitive. Is that just some odd side effect?

Copy link
Contributor Author

@Nerixyz Nerixyz Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because of this:

llvm-project/clang/lib/Driver/ToolChains/MSVC.cpp

Lines 167 to 168 in 7b98280

if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7))
CmdArgs.push_back("-debug");

Copy link
Member

@Michael137 Michael137 Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems plausible. So clang-cl transforms -gdwarf into /Z7? Worth filing an issue to clarify what's going on

Copy link
Member

@Michael137 Michael137 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Z7 the thing that instructs pdb? Vague memory that some other flag is needed

Copy link
Contributor Author

@Nerixyz Nerixyz Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #165614.

# However, in the native PDB plugin, the symbols don't have a size.
@expectedFailureWindows
def test_mulitple_slides(self):
"""Test that a binary can be slid multiple times correctly."""
self.build()
Expand Down
Loading