[VK] Surface validation errors as errors #425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will force tests to fail when validation errors occur so that they fail everywhere instead of just on some devices.
bogner
approved these changes
Oct 22, 2025
| Message = Data->pMessage; | ||
| for (uint32_t I = 0; I < Data->objectCount; I++) | ||
| if (Data->pObjects[I].pObjectName) | ||
| Objects.emplace_back(std::string(Data->pObjects[I].pObjectName)); |
There was a problem hiding this comment.
Calling emplace_back with a temporary is silly - this should just be push_back
Suggested change
| Objects.emplace_back(std::string(Data->pObjects[I].pObjectName)); | |
| Objects.push_back(std::string(Data->pObjects[I].pObjectName)); |
| OS << ": [ " << MessageID << " ]\n"; | ||
| OS << Message; | ||
|
|
||
| for (const auto &S : Objects) |
There was a problem hiding this comment.
I don't think auto helps here.
Suggested change
| for (const auto &S : Objects) | |
| for (const std::string &S : Objects) |
| VkDebugUtilsMessageSeverityFlagBitsEXT MessageSeverity; | ||
| std::string Message; | ||
| std::string MessageID; | ||
| std::vector<std::string> Objects; |
There was a problem hiding this comment.
SmallVector would be slightly more efficient here (it doesn't really matter though)
| llvm::Error Err = llvm::make_error<VKValidationError>(MessageSeverity, Data); | ||
|
|
||
| // Return true to turn the validation error or warning into an error in the | ||
| // vulkan API. This should causes tests to fail. |
There was a problem hiding this comment.
Suggested change
| // vulkan API. This should causes tests to fail. | |
| // vulkan API. This should cause tests to fail. |
Comment on lines
+1333
to
+1337
| // Log verbose an info messages and continue. | ||
| llvm::logAllUnhandledErrors(std::move(Err), llvm::dbgs()); | ||
|
|
||
| // Continue to run even with VERBOSE and INFO messages. | ||
| return VK_FALSE; |
There was a problem hiding this comment.
Second comment here seems a bit redundant, and there's a typo in the first.
Suggested change
| // Log verbose an info messages and continue. | |
| llvm::logAllUnhandledErrors(std::move(Err), llvm::dbgs()); | |
| // Continue to run even with VERBOSE and INFO messages. | |
| return VK_FALSE; | |
| // Log verbose and info messages and continue. | |
| llvm::logAllUnhandledErrors(std::move(Err), llvm::dbgs()); | |
| return VK_FALSE; |
| VkInstance Instance = VK_NULL_HANDLE; | ||
| VkDebugUtilsMessengerEXT DebugMessenger = VK_NULL_HANDLE; | ||
| llvm::SmallVector<std::shared_ptr<VKDevice>> Devices; | ||
| std::optional<llvm::Error> Err = std::nullopt; |
There was a problem hiding this comment.
This could probably just be an llvm::Error that's initialized to Error::success(). If that's more awkward to work with or less clear though this way is totally fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will force tests to fail when validation errors occur so that they fail everywhere instead of just on some devices.