-
Couldn't load subscription status.
- Fork 25
Add tests for maximal reconvergence. #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good couple tests to starts testing convergence. However, the feature checks need to be improved to make sure they run for DirectX as well.
557f48f to
1251f6e
Compare
|
Looks like Feature/MaximalReconvergence/subgroup_uniform_control_flow.test failing for DirectX in different way. Intel clang DirectX: Data: [ 8, 9, 8, 9, 14, 7, 7, 7 ] @spall What is the best way to handle this failure? I'm guessing there are two problems. One in warp and one in the clang compiler. |
so dxc and clang have different results and its determined that the dxc results are correct? Also warp is wrong always? I guess we file an issue on Clang and Warp. @llvm-beanz how should we file an issue on warp for this? |
Co-authored-by: Steven Perron <stevenperron@google.com>
|
| # XFAIL: Clang && Vulkan | ||
|
|
||
| # BUG: https://github.com/llvm/offload-test-suite/issues/490 | ||
| # XFAIL: DirectX && WARP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test works on WARP. It only fails when clang is used.
| # XFAIL: DirectX && WARP | ||
|
|
||
| # BUG: https://github.com/llvm/llvm-project/issues/165288 | ||
| # XFAIL: Clang && DirectX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like clang mtl is failing at well (both tests). It is probably the same issue. XFAIL that one as well.
| # XFAIL: DirectX && WARP | ||
|
|
||
| # BUG: https://github.com/llvm/llvm-project/issues/165288 | ||
| # XFAIL: Clang && DirectX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XFAIL for mtl and clang as well.
d8b8c05 to
99aac0b
Compare
99aac0b to
dec04ff
Compare
Added 2 tests based on the article, subgroup uniform control flow and loop peeling.
Addresses llvm/llvm-project#136930