Make Unescaped Output Fail With Error Severity 10 #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
approved these changes
Apr 15, 2023
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: ready for review
and removed
Progress: approved
labels
fredden
approved these changes
Apr 17, 2023
Member
fredden
left a comment
fredden
left a comment
There was a problem hiding this comment.
I'm re-approving this because the Magento robot messed up the labels.
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
ihor-sviziev
approved these changes
Apr 19, 2023
Contributor
|
@magento import PR to magento-commerce/magento-coding-standard repository |
Contributor
|
@sinhaparul the Pull Request is successfully imported. |
Collaborator
|
@magento import PR to magento-commerce/magento-coding-standard repository |
Contributor
|
@sidolov the Pull Request is successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unescaped output should be grounds for failure - let's mark it as such.