Skip to content

Allow readonly between phpdoc and property name #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Allow readonly between phpdoc and property name #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf43987
allow readonly between phpdoc and property name
sandipklevu May 24, 2023
087b1a2
Merge branch 'magento:develop' into magentocoding-readonly
sandipklevu Jun 12, 2023
889b4d2
Add test case for readonly property
sandipklevu Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Magento2/Sniffs/Commenting/ClassPropertyPHPDocFormattingSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class ClassPropertyPHPDocFormattingSniff extends AbstractVariableSniff
T_NULLABLE,
T_BITWISE_AND,
T_TYPE_UNION,
T_READONLY,
];

/**
Expand Down
10 changes: 10 additions & 0 deletions Magento2/Tests/Commenting/ClassPropertyPHPDocFormattingUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,14 @@ class correctlyFormattedClassMemberDocBlock
* @deprecated This property will be removed in version 1.0.0 without replacement
*/
protected string $deprecatedWithKeyword;

/**
* @var string
*/
protected readonly string $readOnlyString;

/**
* @var int
*/
protected readonly int $readOnlyInteger;
}