Skip to content

Conversation

@senthilengg
Copy link

Description (*)

  1. Plugin for Front Controller to identify whether its a GET or POST request and persist in a Object for later use
  2. Query Parser plugin to identify whether its Query or Mutation since all graphql is POST
  3. Add cache to avoid DB query for repeated requests and serve the attributes from cache

Fixed Issues (if relevant)

  1. Fixes Magento\SalesRule\Model\Plugin\QuoteConfigProductAttributes::afterGetProductAttributes getting triggered on all Cart Queries #40226

Manual testing scenarios (*)

  1. Test view cart and ensure salesrule product attributes are not queried during the first run
  2. Test graphql Mutation and ensure attribute based rules are applied correctly. Use attributes that are custom.
  3. Test all cart actions, billing save, shipping address / method save, payment save and ensure all related rules applicable for shipping methods and payment methods are applied correctly

Questions or comments

Do we need to worry about cache overload with too many attributes ?

@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2025

Hi @senthilengg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@senthilengg
Copy link
Author

@magento run Unit Tests

@senthilengg
Copy link
Author

@magento run Static Tests, WebAPI Tests, Functional Tests CE, Integration Tests, Semantic Version Checker, Magento Health Index, Database Compare

@senthilengg
Copy link
Author

@magento run Static Tests

@senthilengg
Copy link
Author

@magento run Static Tests, Integration Tests

@senthilengg
Copy link
Author

@magento run Static Tests

@senthilengg
Copy link
Author

@magento run Unit Tests, Static Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Magento\SalesRule\Model\Plugin\QuoteConfigProductAttributes::afterGetProductAttributes getting triggered on all Cart Queries

2 participants