Skip to content

Log the similarity between anchor and negatives #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Log the similarity between anchor and negatives #332

wants to merge 3 commits into from

Conversation

@edyoshikun
Copy link
Member

@edyoshikun edyoshikun commented Oct 30, 2025 •
edited
Loading

This PR adds:

  • Logs the cosine and Euclidean distance between the anchor and the negatives.
  • Logs the margin between the cosine similarity between anchor-positive sample and the mean of anchor-negative sample.
  • Tests for the _valid_anchors() to ensure we are getting the right anchor+positive.

@edyoshikun edyoshikun changed the title Log the similarity of anchor and negatives Log the similarity between anchor and negatives Oct 31, 2025
@edyoshikun edyoshikun marked this pull request as ready for review October 31, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxndrkalinin alxndrkalinin Awaiting requested review from alxndrkalinin

@mattersoflight mattersoflight Awaiting requested review from mattersoflight

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edyoshikun