Container: Add initial container for meshtastic-cli #847
Conversation
|
|
oliv3r
force-pushed
the
containerization
branch
from
44cb502 to
0531c91
Compare
oliv3r
changed the title
oliv3r
force-pushed
the
containerization
branch
from
0531c91 to
29755a7
Compare
Just a quick set of files to enable the build of (tagged) containers. Both alpine and debian containers are available (~200MiB/~1.2GiB) allowing us to use meshtastic cli with a quick docker run, instead of having to build/install stuff locally. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
oliv3r
force-pushed
the
containerization
branch
from
29755a7 to
8e9d516
Compare
oliv3r
changed the title
ianmcorvidae
left a comment
ianmcorvidae
left a comment
There was a problem hiding this comment.
One small comment, but in general I think this is good. I haven't actually tested the containerfiles myself but they look like they should work fine and hopefully you did, anyway!
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
We don't use the v prefix for the tags in this repo -- https://github.com/meshtastic/python/tags
I imagine this should probably just build on any tag, or any three-part numeric thing that looks like a version number.
| !extra/ | ||
| !meshtastic/ | ||
| !poetry.lock | ||
| !protobufs/ |
There was a problem hiding this comment.
I can go either way on this, but if this is just for running the CLI itself, we probably don't need to worry about including the protobufs folder. It's really only used as an input for the update-protobufs script that builds actual python stuff in meshtastic/protobuf. If you think it's more useful to include it I don't have a problem with it though.
3 participants
Just a quick set of files to enable the build of (tagged) containers. Both alpine and debian containers are available (~200MiB/~1.2GiB) allowing us to use meshtastic cli with a quick docker run, instead of having to build/install stuff locally.