Skip to content

fix lockup when loading a snapshot which doesn't include bpm or bpb #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: ps-1.13
Choose a base branch
from
Open

fix lockup when loading a snapshot which doesn't include bpm or bpb #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3565a24
fix lockup when loading a snapshot which doesn't include bpm or bpb
rreichenbach May 27, 2025
f9b809f
Fix issue with default and new pedalboards having MIDI mode forced to…
rreichenbach Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mod/host.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3141,8 +3141,11 @@ def snapshot_load(self, idx, from_hmi, abort_catcher, callback):
diffBypass = (self.should_save_addressing_value(addressing, pluginData['bypassed']) and
pluginData['bypassed'] != data['bypassed'])
diffPreset = data['preset'] and data['preset'] != pluginData['preset']
diffBpm = data['bpm'] and data['bpm'] != self.transport_bpm
diffBpb = data['bpb'] and data['bpb'] != self.transport_bpb

bpm = data.get('bpm')
diffBpm = bpm is not None and bpm != self.transport_bpm
bpb = data.get('bpb')
diffBpb = bpb is not None and bpb != self.transport_bpb

if was_aborted or diffBypass:
if addressing is not None:
Expand Down Expand Up @@ -3696,7 +3699,8 @@ def load(self, bundlepath, isDefault=False, abort_catcher=None):
self.pedalboard_path = ""
self.pedalboard_size = [0,0]
self.pedalboard_version = 0
self.midi_aggregated_mode = True
# Don't override MIDI mode for default pedalboards - use the mode from the pedalboard
# self.midi_aggregated_mode = True
#save_last_bank_and_pedalboard(0, "")
else:
self.pedalboard_empty = False
Expand Down