Skip to content

Conversation

@vsyaco
Copy link

@vsyaco vsyaco commented Apr 12, 2013

No description provided.

@michelf
Copy link
Owner

michelf commented Apr 12, 2013

I'm not convinced this is an improvement. On one hand, switch removes the redundancy of $attr ==. On the other hand it requires adding a break everywhere otherwise it'll fall through the next case silently. I'd argue that the later is more error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants