Skip to content

Conversation

@Andarist
Copy link
Contributor

fixes #62675

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Oct 26, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 26, 2025
@jakebailey
Copy link
Member

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 26, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62676/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 193,331k (± 0.79%) 193,272k (± 0.77%) ~ 192,651k 196,324k p=1.000 n=6
Parse Time 1.31s (± 0.39%) 1.30s (± 0.40%) -0.01s (- 0.77%) 1.29s 1.30s p=0.018 n=6
Bind Time 0.72s 0.72s (± 0.71%) ~ 0.72s 0.73s p=0.174 n=6
Check Time 9.73s (± 0.40%) 9.72s (± 0.31%) ~ 9.70s 9.77s p=0.806 n=6
Emit Time 2.75s (± 0.63%) 2.74s (± 1.14%) ~ 2.72s 2.80s p=0.463 n=6
Total Time 14.51s (± 0.31%) 14.49s (± 0.25%) ~ 14.44s 14.53s p=0.333 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 955,117 955,117 ~ ~ ~ p=1.000 n=6
Types 415,619 415,619 ~ ~ ~ p=1.000 n=6
Memory used 1,254,534k (± 0.00%) 1,254,561k (± 0.00%) ~ 1,254,491k 1,254,623k p=0.470 n=6
Parse Time 6.55s (± 0.50%) 6.54s (± 0.81%) ~ 6.48s 6.61s p=1.000 n=6
Bind Time 1.88s (± 0.27%) 1.88s (± 0.40%) ~ 1.87s 1.89s p=0.784 n=6
Check Time 32.15s (± 0.37%) 32.25s (± 0.25%) ~ 32.16s 32.36s p=0.128 n=6
Emit Time 14.84s (± 0.66%) 14.88s (± 0.43%) ~ 14.77s 14.95s p=0.630 n=6
Total Time 55.42s (± 0.37%) 55.55s (± 0.13%) ~ 55.49s 55.65s p=0.229 n=6
mui-docs - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 552,486 552,486 ~ ~ ~ p=1.000 n=6
Types 89 89 ~ ~ ~ p=1.000 n=6
Memory used 827,443k (± 0.00%) 827,428k (± 0.00%) ~ 827,392k 827,442k p=0.107 n=6
Parse Time 8.61s (± 0.25%) 8.69s (± 0.88%) ~ 8.59s 8.75s p=0.124 n=6
Bind Time 2.19s (± 0.34%) 2.19s (± 0.75%) ~ 2.16s 2.21s p=0.548 n=6
Check Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Emit Time 0.27s (± 3.66%) 0.27s (± 3.15%) ~ 0.26s 0.28s p=0.588 n=6
Total Time 11.07s (± 0.26%) 11.14s (± 0.66%) ~ 11.04s 11.21s p=0.170 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,224 1,237,222 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 259,862 259,862 ~ ~ ~ p=1.000 n=6
Memory used 2,486,161k (±11.94%) 2,364,865k (± 0.01%) ~ 2,364,472k 2,365,137k p=0.471 n=6
Parse Time 5.15s (± 1.12%) 5.12s (± 1.38%) ~ 5.03s 5.23s p=0.470 n=6
Bind Time 1.77s (± 0.47%) 1.78s (± 0.78%) ~ 1.76s 1.79s p=0.197 n=6
Check Time 35.17s (± 0.60%) 35.11s (± 0.38%) ~ 34.84s 35.20s p=0.335 n=6
Emit Time 3.01s (± 1.43%) 2.99s (± 2.10%) ~ 2.93s 3.10s p=0.572 n=6
Total Time 45.11s (± 0.51%) 45.01s (± 0.33%) ~ 44.73s 45.15s p=0.689 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,224 1,237,222 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 259,862 259,862 ~ ~ ~ p=1.000 n=6
Memory used 3,158,814k (± 0.01%) 3,064,470k (± 7.53%) ~ 2,593,019k 3,158,921k p=0.471 n=6
Parse Time 8.46s (± 0.93%) 8.44s (± 0.82%) ~ 8.32s 8.51s p=0.336 n=6
Bind Time 2.65s (± 0.66%) 2.65s (± 1.21%) ~ 2.61s 2.70s p=1.000 n=6
Check Time 52.75s (± 0.38%) 52.61s (± 1.01%) ~ 51.54s 52.99s p=0.471 n=6
Emit Time 4.36s (± 2.36%) 4.34s (± 2.21%) ~ 4.20s 4.47s p=0.575 n=6
Total Time 68.24s (± 0.46%) 68.05s (± 0.88%) ~ 66.87s 68.45s p=0.936 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,502 262,500 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 104,038 104,038 ~ ~ ~ p=1.000 n=6
Memory used 440,632k (± 0.01%) 440,662k (± 0.01%) ~ 440,625k 440,719k p=0.521 n=6
Parse Time 3.48s (± 1.06%) 3.49s (± 1.11%) ~ 3.45s 3.54s p=1.000 n=6
Bind Time 1.32s (± 1.24%) 1.32s (± 1.62%) ~ 1.30s 1.35s p=1.000 n=6
Check Time 18.93s (± 0.41%) 18.98s (± 0.18%) ~ 18.92s 19.01s p=0.173 n=6
Emit Time 1.52s (± 1.50%) 1.53s (± 0.68%) ~ 1.52s 1.54s p=0.679 n=6
Total Time 25.24s (± 0.43%) 25.31s (± 0.28%) ~ 25.24s 25.43s p=0.227 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,374 225,374 ~ ~ ~ p=1.000 n=6
Types 94,297 94,297 ~ ~ ~ p=1.000 n=6
Memory used 370,062k (± 0.03%) 370,132k (± 0.02%) ~ 370,026k 370,224k p=0.128 n=6
Parse Time 2.84s (± 0.69%) 2.84s (± 0.76%) ~ 2.81s 2.87s p=0.625 n=6
Bind Time 1.61s (± 1.52%) 1.60s (± 0.88%) ~ 1.58s 1.62s p=0.516 n=6
Check Time 16.51s (± 0.41%) 16.46s (± 0.28%) ~ 16.37s 16.49s p=0.258 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 20.97s (± 0.36%) 20.90s (± 0.25%) ~ 20.82s 20.95s p=0.109 n=6
vscode - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 3,976,785 3,976,785 ~ ~ ~ p=1.000 n=6
Types 1,248,019 1,248,019 ~ ~ ~ p=1.000 n=6
Memory used 3,763,060k (± 0.00%) 3,763,075k (± 0.00%) ~ 3,762,865k 3,763,270k p=1.000 n=6
Parse Time 15.32s (± 1.21%) 15.28s (± 0.31%) ~ 15.23s 15.34s p=0.377 n=6
Bind Time 5.01s (± 1.06%) 5.31s (±12.85%) ~ 5.02s 6.70s p=0.288 n=6
Check Time 102.89s (± 1.86%) 102.29s (± 1.70%) ~ 101.00s 105.42s p=0.689 n=6
Emit Time 40.70s (± 9.83%) 38.66s (±13.25%) ~ 31.20s 47.34s p=0.810 n=6
Total Time 163.92s (± 2.98%) 161.54s (± 2.89%) ~ 158.56s 171.00s p=0.173 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 373,563 373,563 ~ ~ ~ p=1.000 n=6
Types 163,454 163,454 ~ ~ ~ p=1.000 n=6
Memory used 530,081k (± 0.02%) 530,076k (± 0.01%) ~ 529,998k 530,145k p=1.000 n=6
Parse Time 4.52s (± 0.59%) 4.56s (± 0.97%) ~ 4.51s 4.62s p=0.195 n=6
Bind Time 1.94s (± 1.55%) 1.96s (± 1.31%) ~ 1.92s 1.99s p=0.244 n=6
Check Time 22.08s (± 0.45%) 22.16s (± 0.39%) ~ 22.07s 22.26s p=0.228 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 28.54s (± 0.43%) 28.68s (± 0.42%) ~ 28.52s 28.82s p=0.148 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 676,692 676,692 ~ ~ ~ p=1.000 n=6
Types 203,798 203,798 ~ ~ ~ p=1.000 n=6
Memory used 578,564k (± 0.03%) 578,514k (± 0.03%) ~ 578,326k 578,757k p=0.689 n=6
Parse Time 4.17s (± 0.77%) 4.18s (± 0.63%) ~ 4.14s 4.22s p=0.625 n=6
Bind Time 1.34s (± 0.94%) 1.35s (± 1.13%) ~ 1.32s 1.36s p=0.490 n=6
Check Time 20.54s (± 2.15%) 20.75s (± 1.74%) ~ 20.23s 21.04s p=0.689 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.06s (± 1.69%) 26.28s (± 1.38%) ~ 25.77s 26.57s p=0.810 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62676/merge:

Everything looks good!

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

Async for loop falling back to Iterable<T_Sync> even if object implements AsyncIterable<T_Async>.

3 participants