Order JSDoc @param name completions by declaration order #62679
+94
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20183
Summary
@paramname completions now appear in the same order as the function’s parameters.sortTextatCompletions.SortText.LocationPriority; relies on response order for ties (avoids changing existing sortText-sensitive tests)./**doc template expansion.Approach
getJSDocParameterNameCompletionsto:Changed:
src/services/jsDoc.ts(getJSDocParameterNameCompletions)Tests
Added deterministic fourslash tests (no manual blocks):
tests/cases/fourslash/jsDocParamCompletion_filterAlreadyDocumented.tstests/cases/fourslash/jsDocParamCompletion_prefixFiltering.tstests/cases/fourslash/jsDocParamCompletion_skipDestructured.tstests/cases/fourslash/jsDocParamCompletion_optionalAndRest.tstests/cases/fourslash/jsDocParamCompletion_overloadsUseImplementation.tstests/cases/fourslash/jsDocParamCompletion_jsFile.tsExisting related tests still pass:
tests/cases/fourslash/completionsJsdocParamTypeBeforeName.tstests/cases/fourslash/jsdocParameterNameCompletion.tsRisk/compatibility
@paramcompletions. No API or language changes.Performance
Editor impact
@paramname suggestions in declaration order when completing after@param.