Skip to content

Conversation

@jakebailey
Copy link
Member

This is the weird set of commands I have been using locally to keep things up to date while working around the problem of "failing tests" leaving baselines behind. It seems like updatefailing should do something like this, but I think it might be too annoying.

(Sending first without the baseline update to show that it works.)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow to use a more comprehensive process for detecting and updating fourslash test changes. The new approach addresses an issue where failing tests leave behind baselines, which the existing updatefailing command doesn't properly handle.

  • Replaces single updatefailing command with a multi-step process
  • Clears failing test list, regenerates fourslash tests, and iteratively updates baselines
  • Ensures all test state is properly synchronized by removing and regenerating fourslash baselines

@jakebailey jakebailey requested a review from gabritto October 29, 2025 23:28
@jakebailey jakebailey closed this Oct 31, 2025
@jakebailey jakebailey reopened this Oct 31, 2025
@jakebailey jakebailey added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 128ea7d Oct 31, 2025
42 checks passed
@jakebailey jakebailey deleted the jabaile/goofy-fourslash-ci branch October 31, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants