WIP: support different versions in the customized selector #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omentic is attempting to deploy a commit to the misode's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Also I might as well ask -- I was looking at this Customized Worlds generator because I want to take the default Minecraft worldgen, and remove a couple of biomes from it. Is this the thing to use? Seems like it, but I want to make sure... |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hmm, I've now noticed Trial chambers are missing too... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @misode! Thanks for the very handy website :)
I was looking at https://misode.github.io/customized/?tab=biomes and noticed it didn't have the Pale Garden listed, so checked it out and found a hardcoded version that generator is pulling from + no default entry for the Pale Garden. I've added them in here and also added a colour for the Pale Garden in the renders. (This colour was arbitrary, not sure if you have a scheme.)
This generator will now pull from the provided version, i.e., will get the Pale Garden when a version is selected after it was released, but I couldn't quite get it to work smoothly... on my local development host to switch between versions you have to reload after selecting a different version. I had a glance at other similar files when adding the version check but couldn't spot whatever it is that allows the page to update without a manual reload.
If you know where it is I should look for that reload check I can probably add it myself with a pointer, or feel free to edit my commit here directly (if you want to merge this PR, that is). Cheers :)