Skip to content

[Core] Fix the condition and use an or instead a new condition. #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Core] Fix the condition and use an or instead a new condition. #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions experiments/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,16 @@ class Experiment(models.Model):
def is_displaying_alternatives(self):
if self.state == CONTROL_STATE:
return False
elif self.state == ENABLED_STATE:
return True
elif self.state == TRACK_STATE:
elif self.state == ENABLED_STATE or self.state == TRACK_STATE:
return True
else:
raise Exception("Invalid experiment state %s!" % self.state)

def is_accepting_new_users(self):
if self.state == CONTROL_STATE:
if self.state == CONTROL_STATE or self.state == TRACK_STATE:
return False
elif self.state == ENABLED_STATE:
return True
elif self.state == TRACK_STATE:
return False
else:
raise Exception("Invalid experiment state %s!" % self.state)

Expand Down