-
-
Couldn't load subscription status.
- Fork 3.1k
feat: remove log-symbols dependency
#5469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Err, that seems like it might be a blocker. Can you elaborate on that please? |
|
|
IMO we'll need to answer that "maybe" before being able to fully review this PR. Shell/terminal symbols and OSes are notoriously difficult to get right. It's possible that some important supported variants of Powershell and/or Windows would be very broken by this change. I'm not saying "unconditionally no" - rather, "please answer the open questions on this PR". |
|
OK, I've investigated a bit further. In In pre-Windows 11 consoles with the correct code page, the symbols show up as boxes, meaning the terminal font doesn't support them. In Windows 11, everything shows up correctly. This means that the One course of action would be to depend on |
log-symbols dependencylog-symbols dependency
That seems reasonable to me as a first step. I'm very wary of completely dropping detection for any of terminal color/TTY/unicode support/type. Mocha has a lot of legacy users who tend to pop up with reported breakages when these nuanced edge cases get changed. Fun fact: Windows 10 is still in support through October 14, 2025! |
PR Checklist
log-symbolswith something smaller (maybe just inline it?) #5468status: accepting prsOverview
This PR removes the
log-symbolsdependency, inlining its functionality. This removeschalkand its many subdependencies from the dependency tree.We no longer check for explicit Unicode support. In case anyone is running Mocha from the Windows legacy command prompt (and possibly PowerShell?), the characters may not show up properly.
I also noticed that the symbols do not respect
Base.useColors, and never seem to have done so. This might be something to look into in the future.