Skip to content

Conversation

@alxndrsn
Copy link

@alxndrsn alxndrsn commented Oct 21, 2025

Closes #5505

PR Checklist

Overview

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a nice clean fix with a clean unit test. Thanks!

Will leave open a bit in case another maintainer wants to take look too.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (f4e7e54) to head (672e8e6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5506   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files          57       57           
  Lines        4384     4385    +1     
  Branches      846      847    +1     
=======================================
+ Hits         4107     4108    +1     
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: thrown error .expected with null prototype throws TypeError: value.toString is not a function

2 participants