Skip to content

STREAMS-1972(#2): Replace assert with a type check #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

STREAMS-1972(#2): Replace assert with a type check #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion snippets/mongocompat/mongotypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,9 @@ tojsonObject = function(x, indent, nolint, depth) {
}
var lineEnding = nolint ? " " : "\n";
var tabSpace = nolint ? "" : "\t";
assert.eq((typeof x), "object", "tojsonObject needs object, not [" + (typeof x) + "]");
if (typeof x !== "object") {
throw new TypeError(`tojsonObject needs object, not [${typeof x}]`);
}

if (!indent)
indent = "";
Expand Down
16 changes: 16 additions & 0 deletions snippets/mongocompat/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,19 @@ dbRefForSetters.$db = 'newDb';
assert.strictEqual(dbRefForSetters.$db, 'newDb');
assert.strictEqual(dbRefForSetters.db, 'newDb');
assert.strictEqual(dbRefForSetters.toString(), 'DBRef("newColl", ObjectId("507f1f77bcf86cd799439011"), "newDb")');

try {
tojsonObject("not an object");
assert.fail('Should throw TypeError for string');
} catch (e) {
assert(e instanceof TypeError);
assert(e.message.includes('tojsonObject needs object, not [string]'));
}
try {
tojsonObject(true);
assert.fail('Should throw TypeError for boolean');
} catch (e) {
assert(e.message.includes('tojsonObject needs object, not [boolean]'));
}
assert.strictEqual(typeof tojsonObject({ key: "value" }), 'string');
assert.strictEqual(typeof tojsonObject([1, 2, 3]), 'string');