-
Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP-317663: Archive snippets outputs instead of comitting #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lsierant
wants to merge
3
commits into
master
Choose a base branch
from
lsierant/archive-snippets-outputs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
lsierant/search-snippets-fixes-1.4.0
to
master
September 30, 2025 06:26
d495a2a to
946ef97
Compare
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
946ef97 to
7122dd8
Compare
7122dd8 to
5d53e89
Compare
anandsyncs
approved these changes
Oct 16, 2025
5d53e89 to
8ca9eb0
Compare
7b24ec1 to
ba0e494
Compare
MaciejKaras
approved these changes
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
Couple of questions though:
- I see in the code that we are uploading code_snippets output for every patch, including PRs etc. Do we actually need to upload code snippets for PRs? Do we have a cleanup mechanism in S3 for this?
- update_docs_snippets.sh needs to be run manually, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR we will no longer commit snippets outputs back to the repo and just archive them to s3 instead.
Additionally,
scripts/dev/update_docs_snippets.shscripts was updated. But automated snippets updates from CI runs are not part of this PR.When reviewing collapse changes to tests/output directory - all those files (previously comitted outputs) were just deleted.

Proof of Work
Archiving outputs to s3
manual evg run
locally executed update script
Branch was automatically pushed with all gathered snippets and outputs:
https://github.com/10gen/docs-mongodb-internal/compare/MCK-snippets-update-69038706b0fce50007f25a9d?expand=1