-
Notifications
You must be signed in to change notification settings - Fork 23
Use const for helm_chart local chart dir
#532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
MaciejKaras
approved these changes
Oct 16, 2025
fealebenpae
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The local helm chart directory (
helm_chart) that we use to install the operator is being used at a lot of places and we were using the dir name in line without using the defined constant. This would make it harder to use any other dir as helm chart dir/URL, that we are going to do when we start installing helm chart from OCI registry.This PR changes that and tries to use the const everywhere we used the local chart dir (
helm_chart).edit: To make this work I had to move all constants from
tests.conftesttotests.constantsfile to remove circular dependency.Proof of Work
CI in the PR.
Checklist
skip-changeloglabel if not needed