Use Delete Image API to clean up previous images #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlymonkai
reviewed
Oct 28, 2025
packages/inspection-capture-web/src/PhotoCapture/PhotoCapture.tsx
Outdated
Show resolved
Hide resolved
dlymonkai
reviewed
Oct 28, 2025
Comment on lines
41
to
62
| return; | ||
| } | ||
| const imagesToDelete = state.images.filter( | ||
| (image) => image.inspectionId === props.inspectionId && image.sightId === sightId, | ||
| ); | ||
|
|
||
| console.log('Upload succeeded, proceeding to image cleanup.', { imagesToDelete }); | ||
| if (imagesToDelete.length > 0) { | ||
| imagesToDelete.forEach((image) => { | ||
| deleteImage({ imageId: image.id, id: props.inspectionId }) | ||
| .then(() => { | ||
| console.log(`Deleted image with id: ${image.id}`); | ||
| }) | ||
| .catch((error) => { | ||
| console.error(`Failed to delete image with id: ${image.id}`, error); | ||
| }); | ||
| }); | ||
| } | ||
| }, []); | ||
|
|
||
| const onUploadTimeout = useCallback(() => { | ||
| console.log('Upload timed out and there has not been any image deletion.'); |
dlymonkai
reviewed
Oct 28, 2025
| * @param sightId The sight ID associated with the uploaded picture, if applicable. | ||
| */ | ||
| onUploadSuccess?: (durationMs: number) => void; | ||
| onUploadSuccess?: (durationMs: number, sightId?: string) => void; |
There was a problem hiding this comment.
Create a object as discussed
dlymonkai
reviewed
Oct 28, 2025
| console.log('Uploaded image has no sightId, skipping image cleanup.'); | ||
| return; | ||
| } | ||
| const imagesToDelete = state.images.filter( |
There was a problem hiding this comment.
Check the state for other images that need to be deleted
dlymonkai
reviewed
Oct 28, 2025
| } | ||
| }, []); | ||
|
|
||
| const onUploadTimeout = useCallback(() => { |
gabrieltmonkai
force-pushed
the
feat/MN-791/use-deleteImage-api
branch
3 times, most recently
from
8635cea to
89f213d
Compare
Reset state objects containing the deleted image Updated objects to be deleted in State Updated API export and added more tests Added docs Updated Tests Added provisory getSortedImagesBySight function Removed CleanupObserver Added UploadSuccessPayload
gabrieltmonkai
force-pushed
the
feat/MN-791/use-deleteImage-api
branch
from
89f213d to
6891e13
Compare
dlymonkai
reviewed
Nov 3, 2025
| cleanupEventHandlers: UploadEventHandlers; | ||
| } | ||
|
|
||
| function extractOtherImagesToDelete(imagesBySight: Record<string, Image[]>) { |
There was a problem hiding this comment.
could you specify the return type, as it is a best practice
dlymonkai
reviewed
Nov 3, 2025
| return imagesToDelete; | ||
| } | ||
|
|
||
| function groupImagesBySightId(images: Image[], sightIdToSkip: string) { |
There was a problem hiding this comment.
could you specify the return type, as it is a best practice
dlymonkai
reviewed
Nov 3, 2025
| } | ||
|
|
||
| /** | ||
| * Custom hook used to cleanup sights' images of the inspection by deleting the old ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira Ticket Reference : MN-791
Use are take advantage of the
delete imageAPI to clean up the old images of an insight when a new one is taken.Checklist before requesting a review