Skip to content

DO NOT MERGE chore: add submission_timestamp to serp for more accurate order by #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE chore: add submission_timestamp to serp for more accurate order by #8301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d1781
add timestamp to serp for more accurate sorting
kbammarito Oct 21, 2025
547912a
Merge branch 'main' into add-timestamp-to-serp
kbammarito Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql_generators/serp_events_v2/templates/desktop_query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,8 @@ SELECT
search_mode,
normalized_os,
normalized_os_version,
first_run_date
first_run_date,
submission_timestamp
FROM
-- 1 row per impression_id
impressions
Expand Down
3 changes: 3 additions & 0 deletions sql_generators/serp_events_v2/templates/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,3 +233,6 @@ fields:
- mode: NULLABLE
name: first_run_date
type: STRING
- mode: NULLABLE
name: submission_timestamp
type: TIMESTAMP