Skip to content

Conversation

@Frando
Copy link
Member

@Frando Frando commented Oct 30, 2025

Description

Migrates the repo from snafu/n0-snafu to n0-error.

Note: This PR is mostly AI generated after a detailed instruction set on how to do the migration.
I gave the diff a line-by-line review and fixed things up where the AI made mistakes.
Afterwards, I gave the diff another review while adding a few more from_sources and removing manual error mappings.

Breaking Changes

  • All error structs and enum variants now have a meta: n0_error::Meta field
  • All backtrace fields are removed on error enums and structs

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/59/docs/net_tools/

Last updated: 2025-11-03T15:29:29Z

@n0bot n0bot bot added this to iroh Oct 31, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Oct 31, 2025
@Frando Frando changed the title refactor: migrate from snafu/n0-snafu to n0-error refactor!: migrate from snafu/n0-snafu to n0-error Oct 31, 2025
@Frando Frando marked this pull request as ready for review October 31, 2025 13:11
@matheus23
Copy link
Member

Note: Before next release the iroh-metrics dep of portmapper should be bumped to iroh-metrics 0.37 after n0-computer/iroh-metrics#56 is merged & released

I have a hard parsing this sentence. Does this mean this PR is blocked on a release of iroh-metrics?

@Frando
Copy link
Member Author

Frando commented Nov 3, 2025

Note: Before next release the iroh-metrics dep of portmapper should be bumped to iroh-metrics 0.37 after n0-computer/iroh-metrics#56 is merged & released

I have a hard parsing this sentence. Does this mean this PR is blocked on a release of iroh-metrics?

No, the PR is not blocked. But we should do a separate PR that bump iroh-metrics to 0.37 and n0-watcher to 0.4.1 before doing the (breaking) releases of portmapper and netwatch. Reworded the sentence in the PR description.

@Frando Frando requested a review from dignifiedquire November 3, 2025 15:32
@ramfox ramfox merged commit f0029f7 into main Nov 3, 2025
27 of 28 checks passed
@ramfox ramfox deleted the Frando/n0-snafu branch November 3, 2025 16:23
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants