Skip to content

Conversation

@nwx-natew
Copy link
Contributor

Fixed missing or broken links in this KB article so it now points to relative path in docs structure.

@nwx-natew nwx-natew requested review from a team as code owners October 29, 2025 17:40
Copy link

@andrey-isakov-nwx andrey-isakov-nwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwx-natew Hi Nate, I'm confused tbh. Isn't uavr agents script already included in the other PR
#300?

@nwx-natew
Copy link
Contributor Author

@andrey-isakov-nwx It is. I see that the commit that includes it is in this PR as well. My apologies for that; I've spent hours on GitHub but still learning the ropes about best practices with commits.
Does this "break" anything or can the two PRs still be merged in?

@andrey-isakov-nwx
Copy link

@andrey-isakov-nwx It is. I see that the commit that includes it is in this PR as well. My apologies for that; I've spent hours on GitHub but still learning the ropes about best practices with commits. Does this "break" anything or can the two PRs still be merged in?

Not necessarily you will get issues. It depends on what strategy you are going to use for the later one and whether the first one will require some changes in the script.
If no changes is expected and you will go with squash merge for the later one, in theory, it should be fine. But, ideally, I believe we need to avoid duplicated commits in different PRs to be flexible when reviewing. Who knows how #300 goes.. Denis will return on Friday fyi.

@nwx-natew
Copy link
Contributor Author

Honestly, the main point of this PR was just to update the KB article and nothing else.

@andrey-isakov-nwx
Copy link

Honestly, the main point of this PR was just to update the KB article and nothing else.

No problem. If we leave the script here, let's just wait for #300 merged first. So we're sure that uavr script is reviewed and approved appropriately there and doesn't slip unreviewed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants