Misc cleanup of wrong URLs

[jeremymoskowitz-netwrix]

No description provided.

[claude]

PR Review: #318 - Misc cleanup of wrong URLs

Summary

This PR makes extensive URL changes across 327 files (22,092 additions, 2,002 deletions) in the docs/endpointpolicymanager directory. While the intent to clean up URLs is good, I've identified critical issues that must be addressed before merging.

Critical Issues ❌

1. Broken YouTube Link

File: docs/endpointpolicymanager/components/applicationsettingsmanager/manual/extras/appsetentry.md:11

[http://www.policypak.com/videos/sn6j7q1clmq.html](https://www.youtube.com/watch)

Problem: The hyperlink points to https://www.youtube.com/watch which is an incomplete YouTube URL. The /watch endpoint requires a ?v=VIDEO_ID parameter to function.

Impact: Users will encounter a broken/non-functional YouTube page.

Recommendation: Either find the correct YouTube video ID or revert to the original URL.

---

2. URL Text/Hyperlink Mismatch #1

File: docs/endpointpolicymanager/components/applicationsettingsmanager/manual/extras/appsetinternal.md:12

[http://www.policypak.com/videos/bypassing-internal-item-level-targeting-filters.html](http://www.policypak.com/products/endpointpolicymanager-preconfigured-paks.html)

Problem: The link text indicates a video about "bypassing internal item level targeting filters" but the actual hyperlink points to a completely different page about "preconfigured paks".

Impact: Users expecting a video tutorial will land on a product page, causing confusion and broken documentation flow.

Recommendation: Ensure the hyperlink matches the link text content, or update the link text to match the destination.

---

3. URL Text/Hyperlink Mismatch #2

File: docs/endpointpolicymanager/components/applicationsettingsmanager/manual/quickstartwithprecon/acllockdown.md:18

[https://www.policypak.com/video/endpointpolicymanager-acl-lockdown-for-registry-based-applications.html](http://www.policypak.com/videos/bypassing-internal-item-level-targeting-filters.html)

Problem: Link text shows "ACL lockdown for registry-based applications" but the hyperlink points to "bypassing internal item level targeting filters" - completely unrelated topics.

Impact: Documentation mismatch prevents users from finding the correct resource about ACL lockdown.

Recommendation: Fix the hyperlink to point to the correct ACL lockdown video URL.

---

Code Quality & Best Practices ⚠️

Inconsistent Protocol Usage

• Mix of http:// and https:// URLs throughout the codebase
• Recommendation: Standardize on https:// for all policypak.com URLs for security best practices

Inconsistent URL Patterns

Multiple patterns found for similar resources:

• /webinar/ vs /webinar/evaluate.html
• dev.policypak.com still present in some files but removed in others

Recommendation: Establish consistent URL patterns and apply them uniformly.

Self-Referencing URLs

Several instances where URL text is used as both display text and href:

[https://dev.policypak.com/webinar/](https://dev.policypak.com/webinar/)

Recommendation: Use descriptive link text instead of raw URLs for better readability.

---

Positive Changes ✅

1. Support Portal Links: Correctly updated to https://www.netwrix.com/tickets.html#/open-a-ticket
2. dev.policypak.com Migration: Most references appropriately moved to production URLs
3. Thank You Pages: Consistently updated across files

---

Performance Considerations

• No performance issues identified
• Changes are documentation-only and don't affect runtime performance

---

Security Concerns

• Mixed HTTP/HTTPS usage could expose users to non-secure connections
• Recommendation: Upgrade all http://www.policypak.com URLs to https://

---

Test Coverage

Given the scale of changes (327 files), I recommend:

1. Link Validation: Run an automated link checker on all modified markdown files
2. Spot Checks: Manually verify at least 10-15 representative files from different directories
3. Video Links: Specifically test all video URLs to ensure they point to valid, accessible resources

---

Recommended Actions Before Merge

Must Fix (Blocking):

1. ✅ Fix broken YouTube URL in appsetentry.md:11
2. ✅ Fix URL mismatch in appsetinternal.md:12
3. ✅ Fix URL mismatch in acllockdown.md:18
4. ✅ Run link validation tool to identify other similar issues

Should Fix (Strongly Recommended):

5. ⚠️ Standardize on HTTPS protocol for all policypak.com URLs
6. ⚠️ Ensure consistent URL patterns for webinar and video links
7. ⚠️ Review all video URL replacements for accuracy

Nice to Have:

8. 💡 Use descriptive link text instead of raw URLs
9. 💡 Consider using relative links for internal documentation references

---

Conclusion

Recommendation: REQUEST CHANGES ❌

The PR has good intentions but contains critical broken links and URL mismatches that will negatively impact user experience. The three critical issues identified must be fixed before this can be merged. Additionally, given that this appears to be a large-scale automated replacement, I recommend a thorough review to ensure no other similar issues exist in the remaining 324 files.

The scope of changes suggests this may have been a bulk find-and-replace operation. Consider running a link validation tool across all changed files to catch any other issues that may have been introduced.

---

Review conducted using automated analysis of PR changes and manual verification of identified issues.