Skip to content

Refactor reactFormatter to use createRoot for React 18 compatibility #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor reactFormatter to use createRoot for React 18 compatibility #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b522fc
Refactor reactFormatter to use createRoot for React 18 compatibility
aleruizj Dec 8, 2023
096f2d7
added export function
aleruizj Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 14 additions & 23 deletions src/Utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { render } from 'react-dom';
import { createRoot } from "react-dom/client";

export function clone(obj: any) {
return JSON.parse(JSON.stringify(obj));
Expand Down Expand Up @@ -39,26 +39,17 @@ export function isSameObject(a: any, b: any) {
}

export function reactFormatter(JSX: any) {
return function customFormatter(cell: any, formatterParams: any, onRendered: (callback: () => void) => void) {
// cell - the cell component
// formatterParams - parameters set for the column
// onRendered - function to call when the formatter has been rendered
const renderFn = () => {
const cellEl = cell.getElement();
if (cellEl) {
const formatterCell = cellEl.querySelector('.formatterCell');
if (formatterCell) {
const CompWithMoreProps = React.cloneElement(JSX, { cell });
render(CompWithMoreProps, cellEl.querySelector('.formatterCell'));
}
}
return function customFormatter(
cell: any,
formatterParams: any,
onRendered: (callback: () => void) => void
) {
onRendered(() => {
const cellEl = cell.getElement();
const root = createRoot(cellEl);
root.render(JSX);
});

return "<div class='formatterCell'></div>";
};

onRendered(renderFn); // initial render only.

setTimeout(() => {
renderFn(); // render every time cell value changed.
}, 0);
return '<div class="formatterCell"></div>';
};
}
}