-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(lint): bump doc-kit #8275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom type mappings in the invalid-type-reference linting rule by introducing a typeMap option. This allows users to define custom type references that should be considered valid.
- Added
typeMapparameter to theinvalid-type-referencerule - Updated the
testRuleutility to accept rule options - Added test coverage for custom type references
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/remark-lint/src/rules/invalid-type-reference.mjs | Added typeMap parameter to rule function and passed it to transformTypeToReferenceLink |
| packages/remark-lint/src/rules/tests/utils.mjs | Added ruleOptions parameter to testRule utility function |
| packages/remark-lint/src/rules/tests/invalid-type-reference.test.mjs | Added test case for custom type references using the new options parameter |
| packages/remark-lint/src/api.mjs | Added typeMap property to Options typedef |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8275 +/- ##
==========================================
+ Coverage 76.56% 76.57% +0.01%
==========================================
Files 117 117
Lines 9733 9751 +18
Branches 329 330 +1
==========================================
+ Hits 7452 7467 +15
- Misses 2279 2282 +3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
would it be worth pinning to a specific version here? this is like saying |
cc @bmuenzenmeyer