Skip to content

Conversation

@avivkeller
Copy link
Member

Fixes #8271.

Oddly, CSS behaves differently on the dev site than the prod site, so while display: none was respected on all preview sites, display: inline-flex took precedence on the production site.

(Note: A little type fix in the storybook was also added, but it's not needed for this)

Copilot AI review requested due to automatic review settings October 27, 2025 21:34
@avivkeller avivkeller requested a review from a team as a code owner October 27, 2025 21:34
@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 29, 2025 10:44am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CSS specificity issue where the display: inline-flex property was overriding display: none on production, though it worked correctly on preview sites. The fix adds the !important modifier to the md:hidden Tailwind class to ensure it takes precedence.

Key changes:

  • Added !important modifier to md:hidden class in BaseLinkTabs CSS module
  • Removed unused onSelect prop from BaseLinkTabs story

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/ui-components/src/Common/BaseLinkTabs/index.module.css Added !important modifier to md:hidden utility class to fix specificity issue
packages/ui-components/src/Common/BaseLinkTabs/index.stories.tsx Removed unused onSelect prop from story configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (e14424a) to head (eb23310).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8276      +/-   ##
==========================================
+ Coverage   76.56%   76.61%   +0.05%     
==========================================
  Files         117      117              
  Lines        9733     9751      +18     
  Branches      329      328       -1     
==========================================
+ Hits         7452     7471      +19     
+ Misses       2279     2278       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟠 88 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 93 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 95 🟢 96 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuck

@bmuenzenmeyer
Copy link
Contributor

bmuenzenmeyer commented Oct 29, 2025

there still looks to be a viewport size where this is doubling up

image

addressed via eb23310

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit a49f65c Oct 29, 2025
12 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix-css-issue branch October 29, 2025 10:54
@ovflowd
Copy link
Member

ovflowd commented Oct 29, 2025

Gotta love CSS, man.

@ovflowd
Copy link
Member

ovflowd commented Oct 29, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blog Section shows Categories as well as Tabs

5 participants