-
-
Couldn't load subscription status.
- Fork 6.4k
fix(css): ! in md:hidden
#8276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): ! in md:hidden
#8276
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a CSS specificity issue where the display: inline-flex property was overriding display: none on production, though it worked correctly on preview sites. The fix adds the !important modifier to the md:hidden Tailwind class to ensure it takes precedence.
Key changes:
- Added
!importantmodifier tomd:hiddenclass in BaseLinkTabs CSS module - Removed unused
onSelectprop from BaseLinkTabs story
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/src/Common/BaseLinkTabs/index.module.css | Added !important modifier to md:hidden utility class to fix specificity issue |
| packages/ui-components/src/Common/BaseLinkTabs/index.stories.tsx | Removed unused onSelect prop from story configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8276 +/- ##
==========================================
+ Coverage 76.56% 76.61% +0.05%
==========================================
Files 117 117
Lines 9733 9751 +18
Branches 329 328 -1
==========================================
+ Hits 7452 7471 +19
+ Misses 2279 2278 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yuck
|
there still looks to be a viewport size where this is doubling up
addressed via eb23310 |
|
Gotta love CSS, man. |


Fixes #8271.
Oddly, CSS behaves differently on the dev site than the prod site, so while
display: nonewas respected on all preview sites,display: inline-flextook precedence on the production site.(Note: A little type fix in the storybook was also added, but it's not needed for this)