-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add web-infra onboarding docs #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flakey5
wants to merge
8
commits into
nodejs:main
Choose a base branch
from
flakey5:flakey5/5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d7cac96
Add web-infra onboarding docs
flakey5 dbb4402
Merge branch 'main' into flakey5/5
ovflowd adaaff6
Apply suggestions from code review
flakey5 2dc9f13
review
flakey5 64e48f0
Apply suggestions from code review
flakey5 fbe5111
Apply suggestions from code review
flakey5 6ecb18b
Apply suggestions from code review
flakey5 64bc2c1
Update onboarding/web-infra.md
flakey5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # @nodejs/web-infra Onboarding | ||
|
|
||
| This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). | ||
|
|
||
| Please note these tasks should only be performed after an individual's nomination has passed. | ||
| To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). | ||
|
|
||
| ## Tasks | ||
|
|
||
| - [ ] Add the **Nominee** to the @nodejs/web-infra team on GitHub. | ||
| - [ ] The **Nominee** should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. | ||
| - [ ] Grant the **Nominee** access to Sentry. | ||
| - [ ] The **Nominee** should enable physical or passkey 2FA on their Sentry account. | ||
| - [ ] Grant the **Nominee** access to Vercel. | ||
| - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. | ||
avivkeller marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email)) | ||
| - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) | ||
| - [ ] [`nodejs-vercel`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241) | ||
| - [ ] An OpenJS Slack Admin should add their Slack account to the `nodejs-website-team` team. | ||
|
|
||
| ### Recommendations | ||
|
|
||
| - [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account. | ||
| - [ ] The **Nominee** should have any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. | ||
| - [ ] The **Nominee** should sign their Git commits. | ||
|
|
||
| ## Notes | ||
|
|
||
| There currently is not a set level of access that @nodejs/web-infra members have on Cloudflare. | ||
|
|
||
| Should you need additional access, it may be granted, however, access is not given by default since we do not control it. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this uniform w/ https://github.com/nodejs/web-team/blob/main/onboarding/nodejs-website.md?plain=1
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the two paragraphs since it gives a general outline and explicitly states when these steps should happen. While both can be inferred implicitly, I still think it's better to explicitly state these so avoid confusion or misinterpretation regardless of how unlikely