Skip to content

#16: Properly check return type from safe_float() #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#16: Properly check return type from safe_float() #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,31 +185,31 @@ def iss_pass():
lat = request.args.get('lat', False)
if lat:
lat = safe_float(lat, (-90.0, 90.0))
if not lat:
if lat is False:
return {"message": "failure", "reason": "Latitude must be number between -90.0 and 90.0"}, 400
else:
return {"message": "failure", "reason": "Latitude must be specified"}, 400

lon = request.args.get('lon', False)
if lon:
lon = safe_float(lon, (-180.0, 180.0))
if not lon:
return {"message": "failure", "reason": "Longitue must be number between -180.0 and 180.0"}, 400
if lon is False:
return {"message": "failure", "reason": "Longitude must be number between -180.0 and 180.0"}, 400
else:
return {"message": "failure", "reason": "Longitude must be specified"}, 400

alt = request.args.get('alt', False)
if alt:
alt = safe_float(alt, (0, 10000))
if not alt:
if alt is False:
return {"message": "failure", "reason": "Altitude must be number between 0 and 10,000"}, 400
else:
alt = 100

n = request.args.get('n', False)
if n:
n = safe_float(n, (1, 100))
if not n:
if n is False:
return {"message": "failure", "reason": "Number of passes must be number between 1 and 100"}, 400
else:
n = 5
Expand Down