fix(streaming): skip SSE events with no data to prevent JSONDecodeError #2721
      
        
          +80
        
        
          −0
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes an issue where SSE events containing only meta-fields (retry, id, event) but no data field would cause JSONDecodeError when the SDK tried to parse empty strings as JSON.
Per the SSE specification (WHATWG HTML § 9.2), retry directives and other meta-only events are valid and should not be treated as data events:
The SDK's SSE decoder correctly parses these events, setting the retry field but leaving data empty. However, the
Stream.__stream__()andAsyncStream.__stream__()methods were attempting to call.json()on all events, including those with empty data, leading toJSONDecodeError.Changes:
Stream.__stream__()to skip events with empty/whitespace dataAsyncStream.__stream__()to skip events with empty/whitespace dataThe fix ensures that only events with actual data are parsed as JSON, preventing the error:
that occurred when trying to parse empty strings.
Example error this fixes:
Changes being requested
Additional context & links