build: bump minimum python version to 3.9 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the minimum Python version to 3.9 to prevent installing on older versions where the
dict[]andlist[]typehint syntax (PEP 585) is unsupported.Even if merged and released now though, I believe
pip install opengsqwill automatically install older versions where the package alleges its compatibility, e.g. v0.1.0 to v3.5.0. v3.2.0 is the latest version I could get to run on Python 3.8, having briefly tested it by runningpy -m opengsq.protocols.minecraft.Perhaps a hotfix could also be released that contains the incorrect version specifier and raises an ImportError if they're on Python <3.9, clearly explaining to the user that they should downgrade to opengsq 3.2.0? That should catch anyone on 3.8 or older and help guide them to the correct opengsq version, as long as they haven't pinned their opengsq version to exactly 3.3.0-3.5.0.