-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370774: Merge ModRefBarrierSet into CardTableBarrierSet #28013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 108 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/cc hotspot-gc |
|
@albertnetymk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merge a class into its sole subclass.
Many files are changed in this PR, and they can be largely divided into two groups, moving content of
ModRefBarrierSetintoCardTableBarrierSet(src/hotspot/share/gc/) and platform specific moving content ofModRefBarrierSetAssemblerintoCardTableBarrierSetAssembler(src/hotspot/cpu/).Test: tier1-5 for x64 and aarch64; GHA
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28013/head:pull/28013$ git checkout pull/28013Update a local copy of the PR:
$ git checkout pull/28013$ git pull https://git.openjdk.org/jdk.git pull/28013/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28013View PR using the GUI difftool:
$ git pr show -t 28013Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28013.diff
Using Webrev
Link to Webrev Comment