Skip to content

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Oct 28, 2025

This broke recently because we expanded the scope of the assertion to check all regions. However, there are times when the pin status for a region is only updated if the region belongs to the generation being collected. This change restores the previous behavior of the assertion.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370667: TestPinnedGarbage.java intermittent trigger assert Region \d+ pinning status is inconsistent (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28027/head:pull/28027
$ git checkout pull/28027

Update a local copy of the PR:
$ git checkout pull/28027
$ git pull https://git.openjdk.org/jdk.git pull/28027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28027

View PR using the GUI difftool:
$ git pr show -t 28027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28027.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant