8370667: TestPinnedGarbage.java intermittent trigger assert Region \d+ pinning status is inconsistent #28027
+13
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke recently because we expanded the scope of the assertion to check all regions. However, there are times when the pin status for a region is only updated if the region belongs to the generation being collected. This change restores the previous behavior of the assertion.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28027/head:pull/28027$ git checkout pull/28027Update a local copy of the PR:
$ git checkout pull/28027$ git pull https://git.openjdk.org/jdk.git pull/28027/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28027View PR using the GUI difftool:
$ git pr show -t 28027Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28027.diff
Using Webrev
Link to Webrev Comment