- 
                Notifications
    
You must be signed in to change notification settings  - Fork 199
 
Fix mirror config for v6-primary #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           /test e2e-metal-ipi-ovn-dualstack-v6  | 
    
| 
           /test e2e-metal-ipi-ovn-dualstack-v6 I flipped this back to draft because I'm not necessarily expecting it to work yet, but I want to see how it behaves in CI since it has been different from my local results up until now.  | 
    
| 
           /test e2e-metal-ipi-ovn-dualstack-v6 Cluster deployed this time but the job failed on image stream import. Seems unrelated, but let's see if it reproduces.  | 
    
1a50b9c    to
    19f63d2      
    Compare
  
    19f63d2    to
    4c80763      
    Compare
  
    | 
           /test e2e-metal-ipi-ovn-dualstack-v6  | 
    
    
      
        2 similar comments
      
    
  
    | 
           /test e2e-metal-ipi-ovn-dualstack-v6  | 
    
| 
           /test e2e-metal-ipi-ovn-dualstack-v6  | 
    
| 
           /test e2e-metal-ipi-ovn-dualstack-v6 Let's see if it fails in yet another different way.  | 
    
4c80763    to
    ffa241b      
    Compare
  
    | 
           [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 
      Approvers can indicate their approval by writing   | 
    
| 
           /test e2e-metal-ipi-ovn-dualstack-v6 Trying with a single BMC driver.  | 
    
| 
           /test e2e-metal-ipi-ovn-dualstack-v6  | 
    
It turns out we do need to mirror images for v6-primary clusters because during provisioning they only get an IP from the primary family, which means they can't pull images from the public ipv4 image registries. This fixes the logic so it is all consistent where it needs to be so v6-primary deployments will work as intended by default.
ffa241b    to
    640b769      
    Compare
  
    | 
           /test e2e-metal-ipi-ovn-dualstack-v6  | 
    
| 
           @cybertron: The following tests failed, say  
 Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.  | 
    
It turns out we do need to mirror images for v6-primary clusters because during provisioning they only get an IP from the primary family, which means they can't pull images from the public ipv4 image registries. This fixes the logic so it is all consistent where it needs to be so v6-primary deployments will work as intended by default.