Skip to content

Conversation

@jhixson74
Copy link
Member

@jhixson74 jhixson74 commented Oct 29, 2025

This PR depends on openshift/api#2480

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

@jhixson74: This pull request references CORS-4277 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

@jhixson74: This pull request references CORS-4277 which is a valid jira issue.

In response to this:

This PR depends on openshift/api#2480

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-1of2 4897e16 link true /test e2e-aws-serial-1of2
ci/prow/e2e-aws-serial-2of2 4897e16 link true /test e2e-aws-serial-2of2
ci/prow/unit 4897e16 link true /test unit
ci/prow/e2e-aws-operator 4897e16 link true /test e2e-aws-operator
ci/prow/govet 4897e16 link true /test govet
ci/prow/e2e-aws 4897e16 link true /test e2e-aws
ci/prow/okd-scos-images 4897e16 link true /test okd-scos-images
ci/prow/okd-scos-e2e-aws-ovn 4897e16 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-upgrade 4897e16 link true /test e2e-aws-upgrade
ci/prow/images 4897e16 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks.

Could we add a similar validation in the machine-api-operator webhooks and a bunch of unit tests? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants