Skip to content

OTA-1626: Handle unknown operators #30402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OTA-1626: Handle unknown operators #30402

wants to merge 1 commit into from

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Oct 20, 2025 •
edited
Loading

Following up [1], the function parseClusterOperatorNames
raises up an error if it gets unknown operators which is a
result of CVO's producing a malformed message. It leads to
a failure associated to component "Cluster Version Operator".

[1]. #30269 (comment)

/hold

need to rebase after #30269 gets in

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

/hold

need to rebase after #30269 gets in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@openshift-trt
Copy link

openshift-trt bot commented Oct 21, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: bb48594

  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker cleanup" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker collection" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker interval construction" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker preparation" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker setup" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker test evaluation" [Total: 9, Pass: 9, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][Jira:"Cluster Version Operator"] monitor test cluster-version-checker writing to storage" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:cluster-version-checker][bz-Cluster Version Operator] cluster version should not report Failing=Unknown during a normal cluster upgrade" [Total: 9, Pass: 9, Fail: 0, Flake: 0]

@hongkailiu hongkailiu force-pushed the OTA-1626-followup branch 2 times, most recently from d76087c to 0476313 Compare October 23, 2025 13:21
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Following up [1], the function parseClusterOperatorNames
raises up an error if it gets unknown operators which is a
result of CVO's producing a malformed message. It leads to
a failure associated to component "Cluster Version Operator".

[1]. #30269 (comment)

/hold

need to rebase after #30269 gets in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@hongkailiu
OTA-1626: Handle unknown operators
3c13a83 
Following up [1], the function `parseClusterOperatorNames`
raises up an error if it gets unknown operators which is a
result of CVO's producing a malformed message. It leads to
a failure associated to component "Cluster Version Operator".

[1]. openshift#30269 (comment)
@openshift-trt
Copy link

openshift-trt bot commented Oct 23, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 3c13a83

  • "Import the release payload "nightly-arm64" from an external source" [Total: 2, Pass: 2, Fail: 0, Flake: 0]

@hongkailiu
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bb48594 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial-2of2 3c13a83 link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DavidHurta
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidHurta, hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu
Copy link
Member Author

/hold

An issue is reported https://redhat-internal.slack.com/archives/C01CQA76KMX/p1761317258048499?thread_ts=1760731536.268309&cid=C01CQA76KMX

Let us fix that first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@PratikMahajan PratikMahajan Awaiting requested review from PratikMahajan

1 more reviewer

@DavidHurta DavidHurta DavidHurta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DavidHurta DavidHurta

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hongkailiu @openshift-ci-robot @DavidHurta @openshift-merge-robot