Implement several options for the GraphTool in hardcopy that should have been implemented before. #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
graphtool-hardcopy-scale
branch
3 times, most recently
from
94ff70a to
d7a4e41
Compare
…ave been implemented before. If the `scaleX`, `scaleSymbolX`, `scaleY`, `scaleSymbolY`, or `coordinateHintsType` options are used then the axis ticks and labels are adjusted in the JSXGraph HTML output for the GraphTool, but not in hardcopy. This was an oversight that I didn't do this when these options were implemented. I also added minor ticks to the hardcopy. Those were also never implemented. The documentation for the `scaleX` and `scaleY` options was also corrected. I misstated the way that this is handled by JSXGraph.
drgrice1
force-pushed
the
graphtool-hardcopy-scale
branch
from
d7a4e41 to
84233a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
scaleX,scaleSymbolX,scaleY,scaleSymbolY, orcoordinateHintsTypeoptions are used then the axis ticks and labels are adjusted in the JSXGraph HTML output for the GraphTool, but not in hardcopy.This was an oversight that I didn't do this when these options were implemented.
I also added minor ticks to the hardcopy. Those were also never implemented.
The documentation for the
scaleXandscaleYoptions was also corrected. I misstated the way that this is handled by JSXGraph.