feat: expectation pattern support #2941
Open
+1,020
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Closed
csviri
force-pushed
the
expectation-simple
branch
from
90bebc4 to
ac807a7
Compare
csviri
changed the title
openshift-merge-robot
added
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
6b9d9a3 to
4da5d2b
Compare
openshift-merge-robot
removed
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
ca4c8a2 to
c3c33bc
Compare
csviri
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
csviri
force-pushed
the
expectation-simple
branch
from
838d1a3 to
4c1de74
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
expectation-simple
branch
from
cfde8f5 to
603ac9d
Compare
xstefank
requested changes
Oct 31, 2025
| import io.fabric8.kubernetes.api.model.HasMetadata; | ||
|
|
||
| record RegisteredExpectation<P extends HasMetadata>( | ||
| LocalDateTime registeredAt, Duration timeout, Expectation<P> expectation) { |
There was a problem hiding this comment.
registeredAt should probably not be left over to the caller, we can set it in the constructor
There was a problem hiding this comment.
not sure how do you mean it, you mean the user should provide the regsiteredAt?
|
|
||
| assertThat(result.isExpectationPresent()).isTrue(); | ||
| assertThat(result.isTimedOut()).isTrue(); | ||
| assertThat(expectationManager.isExpectationPresent(configMap)).isTrue(); |
There was a problem hiding this comment.
TBH I find this a little strange. Maybe timedout expectation should be handled differently. Because is it present after it timeouts?
There was a problem hiding this comment.
The idea is that we preserv that state, since user for sure want to handle that situation when the expectation is timed out, so we dont't remove timed out expectation. This is what you mean?
| expectationManager.setExpectation(configMap, Duration.ofMinutes(5), expectation); | ||
| Optional<String> name = expectationManager.getExpectationName(configMap); | ||
|
|
||
| assertThat(name).contains(expectedName); |
There was a problem hiding this comment.
it's an optional, so I guess this is right.
| expectationManager.setExpectation(configMap, Duration.ofMinutes(5), expectation); | ||
| assertThat(expectationManager.isExpectationPresent(configMap)).isTrue(); | ||
|
|
||
| expectationManager.cleanup(configMap); |
There was a problem hiding this comment.
I prefer removeExpectation
There was a problem hiding this comment.
yeah, sounds a bit better, thx, changed!
| return UpdateControl.noUpdate(); | ||
| } | ||
| } else { | ||
| // checks the expectation if it is fulfilled also removes it, |
There was a problem hiding this comment.
not sure what do you mean... pls ellaborate
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
|
thank you @xstefank for all the fixes in javadocs and other suggestions!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue