[FSSDK-11991] update: expose CMAB cache configuration options #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updating type hints
…ze and TTL configuration
Mat001
requested changes
Oct 28, 2025
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
default cmab cache size to be 10000
optimizely/cmab/cmab_service.py
Outdated
|
|
||
| NUM_LOCK_STRIPES = 1000 | ||
| DEFAULT_CMAB_CACHE_TIMEOUT = 30 * 60 # 30 minutes | ||
| DEFAULT_CMAB_CACHE_SIZE = 1000 |
Contributor
There was a problem hiding this comment.
I think this needs to be 10000.
Just like in ODP.
Contributor
There was a problem hiding this comment.
IN odp we have 10000 here:
python-sdk/optimizely/helpers/enums.py
Line 233 in 116d23a
Mat001
requested changes
Oct 28, 2025
optimizely/cmab/cmab_service.py
Outdated
|
|
||
| NUM_LOCK_STRIPES = 1000 | ||
| DEFAULT_CMAB_CACHE_TIMEOUT = 30 * 60 # 30 minutes | ||
| DEFAULT_CMAB_CACHE_SIZE = 1000 |
Contributor
There was a problem hiding this comment.
IN odp we have 10000 here:
python-sdk/optimizely/helpers/enums.py
Line 233 in 116d23a
FarhanAnjum-opti
deleted the
farhan/FSSDK-11991-expose-cmab-cache-config-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also includes CMAB bugbash fixes
Test plan
All existing unit test and FSC should pass
Issues
FSSDK-11991