Skip to content

Conversation

@loicdiridollou
Copy link
Member

Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the description in #1419, it seems the following tests are yet to be added:

  • When the base instance is not of DatetimeIndex but just of a normal Index, .where also works with the changes
  • other being a Series

Please make the tests complete. Thanks!

@loicdiridollou
Copy link
Member Author

Converting to draft until response from pandas team.

@loicdiridollou loicdiridollou marked this pull request as ready for review October 27, 2025 11:50
@loicdiridollou
Copy link
Member Author

Okay so this is allowed by pandas so I will clean the PR tonight.

@cmp0xff cmp0xff added the Index Related to the Index class or subclasses label Oct 28, 2025
Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts so that we can merge 🙂

Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @loicdiridollou !

@cmp0xff cmp0xff merged commit fe7e8b4 into pandas-dev:main Oct 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Index Related to the Index class or subclasses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index.where(..., other) should support other with more than array-like

3 participants