GH1441 Allow for axis argument in DataFrame.pct_change #1450
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
reviewed
Oct 25, 2025
| fill_method: None = None, | ||
| freq: Frequency | dt.timedelta | None = ..., | ||
| fill_value: Scalar | NAType | None = ..., | ||
| axis: Axis | None = ..., |
There was a problem hiding this comment.
What about **kwargs? Can we just add **kwargs: Any or copy-paste all additional arguments from DataFrame.shift or Series.shift?
There was a problem hiding this comment.
So using the actual arguments and not the kwargs was something Marco started a while ago - since it helps with readability - to know what needs to be passed, you ensure fuller typing. I have added the axis, the other argument in shift method is suffix but it does not apply in our case (does not work when period is an int).
So these are all the args we can pass and they are fully typed.
Let me know what you think about the approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axisparameter in DataFrame.pct_change() type annotations #1441assert_type()to assert the type of any return value