feat: typing plotting and io
#1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
added
IO Data
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
looks good, just a minor comment + question
MarcoGorelli
approved these changes
Oct 29, 2025
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
i'd suggest using Mapping in __deepcopy__ as that's usually preferred for arguments, other than that looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example for the
ruff-driven development in #1448, here I complete the typing forplottingandioand remove the correspondingruff-ignore sections.