STY: use strict zip in pandas/tests/window
#62852
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorexsalvo
force-pushed
the
fix/rule_B905_tests-window
branch
2 times, most recently
from
654e2c2 to
20f9d14
Compare
zorexsalvo
force-pushed
the
fix/rule_B905_tests-window
branch
from
20f9d14 to
b8a0fc9
Compare
mroeschke
requested changes
Oct 27, 2025
zorexsalvo
force-pushed
the
fix/rule_B905_tests-window
branch
from
2270859 to
8dcd766
Compare
zorexsalvo
force-pushed
the
fix/rule_B905_tests-window
branch
from
8dcd766 to
a7be4e2
Compare
mroeschke
requested changes
Oct 28, 2025
| DataFrame(values, index=df.loc[index, "C"]) for (values, index) in expected | ||
| ] | ||
| for expected, actual in zip(expecteds, df.rolling(window, on="C")): | ||
| for expected, actual in zip(expecteds, df.rolling(window, on="C"), strict=False): |
There was a problem hiding this comment.
Hi @mroeschke some of the parametrize cases have mismatch lengths which when run with strict=True consistently raise test_iter_rolling_dataframe[None-expected7-2-None] - ValueError: zip() argument 2 is shorter than argument 1
One example is
pandas/pandas/tests/window/test_rolling.py
Line 749 in a7be4e2
None for the df means no valid rolling object, so no windows generated. But the expected side has one item.
There was a problem hiding this comment.
I see. Thanks for highlighting.
mroeschke
approved these changes
Oct 29, 2025
|
Thanks @zorexsalvo |
zhangbowen-coder
pushed a commit
to zhangbowen-coder/pandas
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.