Skip to content

Conversation

@georginas05
Copy link
Contributor

This is an edit to an existing branching statement inside python_parser.py and is fixed for the Python engine.

@georginas05 georginas05 changed the title 62739 CSV Double Quotes BUG: CSV Double Quotes Oct 26, 2025
@zephyrieal
Copy link
Contributor

Thanks for pointing that out! I've updated it.

@mroeschke mroeschke added the IO CSV read_csv, to_csv label Oct 27, 2025
@mroeschke mroeschke requested a review from rhshadrach October 27, 2025 20:30
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

- Bug in :meth:`HDFStore.get` was failing to save data of dtype datetime64[s] correctly (:issue:`59004`)
- Bug in :meth:`HDFStore.select` causing queries on categorical string columns to return unexpected results (:issue:`57608`)
- Bug in :meth:`MultiIndex.factorize` incorrectly raising on length-0 indexes (:issue:`57517`)
- Bug in :meth:`python_parser` where :class:`MyDialect` did not appropriately skip a line when instructed, causing Empty Data Error (:issue:`62739`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatsnew notes are for users and should only refer to the public API; both python_parser and MyDialect are not public. Can you rewrite - just :func:`read_csv` I think.

Copy link
Contributor

@zephyrieal zephyrieal Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just wondering if it should be :meth: instead of :func? it seems that other mentions of read_csv uses :meth: tag instead

Copy link
Member

@rhshadrach rhshadrach Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no difference in the generated docs, so not a big deal either way, but read_csv is a function in the pandas namespace and not a method on a class.

@zephyrieal
Copy link
Contributor

pre-commit.ci autofix

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added the Bug label Nov 4, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Nov 4, 2025
@rhshadrach rhshadrach changed the title BUG: CSV Double Quotes BUG: read_csv skipping a line with double quotes Nov 4, 2025
@rhshadrach rhshadrach merged commit f33207b into pandas-dev:main Nov 4, 2025
47 checks passed
@rhshadrach
Copy link
Member

rhshadrach commented Nov 4, 2025

Thanks @georginas05 and @zephyrieal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug IO CSV read_csv, to_csv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: reading space-delimited CSV file and skipping first row with double quote in it fails

4 participants