TST: ensuring bins in cut during tiling are predictably small #62868
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failing test when doing mutation in [core/reshape/tile.py:387](https://github.com/pandas-dev/pandas/blob/v2.2.1/pandas/core/reshape/tile.py#L387)
mx += 0.001 * abs(mx) if mx != 0 else 0.001 And it passes when the mutation doesn't exist as seen in CI |
5 tasks
mroeschke
reviewed
Oct 27, 2025
pandas/tests/reshape/test_cut.py
Outdated
| def test_single_bin_edge_adjustment(): | ||
| # gh-58517 - test edge adjustment when all values are the same | ||
| # mutation on _nbins_to_bins | ||
| data = [0.1, 0.1, 0.1] |
There was a problem hiding this comment.
Could you use pytest.mark.parameterize with data, data_neg and data_tiny?
There was a problem hiding this comment.
Ooh thank you! My bad
mroeschke
added
the
Testing
Nikhil-Narayanan
force-pushed
the
tile-muttest
branch
from
2afe0f3 to
0599336
Compare
mroeschke
approved these changes
Oct 29, 2025
|
Thanks @Nikhil-Narayanan |
zhangbowen-coder
pushed a commit
to zhangbowen-coder/pandas
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.