Skip to content

array offset (level, message, context) should not be guarantee for hasRecord() #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

array offset (level, message, context) should not be guarantee for hasRecord() #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/Test/TestLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* It records all records and gives you access to them for verification.
*
* @psalm-type log_record_array array{level: string, message: string|\Stringable, context: array{exception?: \Throwable}}
* @psalm-type has_record_array array{level?: string, message?: string|\Stringable, context?: array<array-key, mixed>}
*/
class TestLogger implements LoggerInterface
{
Expand Down Expand Up @@ -57,7 +58,7 @@ public function hasRecords($level)
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
* @param string $level
* @return bool
*/
Expand Down Expand Up @@ -136,63 +137,63 @@ public function __call($method, $args)
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasEmergency($record): bool
{
return $this->hasRecord($record, 'emergency');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasAlert($record): bool
{
return $this->hasRecord($record, 'alert');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasCritical($record): bool
{
return $this->hasRecord($record, 'critical');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasError($record): bool
{
return $this->hasRecord($record, 'error');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasWarning($record): bool
{
return $this->hasRecord($record, 'warning');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasNotice($record): bool
{
return $this->hasRecord($record, 'notice');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasInfo($record): bool
{
return $this->hasRecord($record, 'info');
}

/**
* @param log_record_array|string $record
* @param has_record_array|string $record
*/
public function hasDebug($record): bool
{
Expand Down